auto switch for task bar icon color added

Author: patrickiel

src/VolumeScroller/App.xaml.cs

@@ -16,6 +16,7 @@ namespace VolumeScroller;
 public partial class App : Application
 {
     private AudioController audioController;
+    private static MainViewModel mainViewModel;
 
     public void App_Startup(object sender, StartupEventArgs e)
     {
@@ -49,13 +50,14 @@ private static void ShutdownIfAlreadyRunning()
     private static void InitializeTrayIcon()
     {
         MainModel main = new();
-        MainViewModel mainViewModel = new(main);
+        mainViewModel = new(main);
         MainWindow mainWindow = new(mainViewModel);
         mainWindow.Show();
     }
 
     private void Application_Exit(object sender, ExitEventArgs e)
     {
+        mainViewModel.Dispose();
         audioController.Dispose();
         SystemEvents.DisplaySettingsChanged -= DisplaySettingsChanged;
     }

src/VolumeScroller/MainModel.cs

@@ -7,16 +7,6 @@ public MainModel()
         ResetRunOnStartup();
     }
 
-    public bool DarkTaskbar
-    {
-        get => Properties.Settings.Default.DarkTaskbar;
-        set
-        {
-            Properties.Settings.Default.DarkTaskbar = value;
-            Properties.Settings.Default.Save();
-        }
-    }
-
     public int Increment
     {
         get => Properties.Settings.Default.Increment;

src/VolumeScroller/MainViewModel.cs

@@ -1,34 +1,27 @@
-namespace VolumeScroller;
+using Microsoft.Win32;
 
-public class MainViewModel : ViewModelBase
+namespace VolumeScroller;
+
+public class MainViewModel : ViewModelBase, IDisposable
 {
     private readonly MainModel mainModel;
-    private bool darkTaskbar;
     private int increment;
     private bool runOnStartup;
+    private string taskBarIconPath;
 
     public MainViewModel(MainModel mainModel)
     {
         this.mainModel = mainModel;
-        darkTaskbar = mainModel.DarkTaskbar;
         increment = mainModel.Increment * 2;
         runOnStartup = mainModel.RunOnStartup;
+        TaskBarIconPath = GetTaskbarIconPath();
+        SystemEvents.UserPreferenceChanged += UserPreferenceChanged;
     }
 
     public string TaskBarIconPath
-        => DarkTaskbar
-            ? "/Resources/VolumeScroller_dark.ico"
-            : "/Resources/VolumeScroller_light.ico";
-
-    public bool DarkTaskbar
     {
-        get => darkTaskbar;
-        set
-        {
-            SetProperty(ref darkTaskbar, value);
-            mainModel.DarkTaskbar = value;
-            OnPropertyChanged(nameof(TaskBarIconPath));
-        }
+        get => taskBarIconPath;
+        set => SetProperty(ref taskBarIconPath, value);
     }
 
     public bool RunOnStartup
@@ -50,4 +43,20 @@ public int Increment
             mainModel.Increment = value / 2;
         }
     }
+
+    public void Dispose() 
+        => SystemEvents.UserPreferenceChanged -= UserPreferenceChanged;
+
+    private void UserPreferenceChanged(object sender, EventArgs e) 
+        => TaskBarIconPath = GetTaskbarIconPath();
+
+    private static string GetTaskbarIconPath()
+    {
+        RegistryKey key = Registry.CurrentUser.OpenSubKey(@"Software\Microsoft\Windows\CurrentVersion\Themes\Personalize");
+        var isLightTheme = (int)key.GetValue("SystemUsesLightTheme") == 1;
+
+        return isLightTheme
+            ? "/Resources/VolumeScroller_light.ico"
+            : "/Resources/VolumeScroller_dark.ico";
+    }
 }

src/VolumeScroller/MainWindow.xaml

@@ -57,14 +57,6 @@
                     AutoToolTipPlacement="TopLeft"
                     IsSnapToTickEnabled="True"
                     TickFrequency="2" />
-            <Label Content="Dark taskbar"
-                   Grid.Row="1"
-                   Grid.Column="0"
-                   HorizontalAlignment="Right" />
-            <CheckBox Grid.Row="1"
-                      Grid.Column="1"
-                      VerticalAlignment="Center"
-                      IsChecked="{Binding DarkTaskbar, Mode=TwoWay}"/>
             <Label Content="Run on startup"
                    Grid.Row="2"
                    Grid.Column="0"

src/VolumeScroller/Properties/Settings.Designer.cs

@@ -5,9 +5,6 @@
     <Setting Name="Increment" Type="System.Int32" Scope="User">
       <Value Profile="(Default)">1</Value>
     </Setting>
-    <Setting Name="DarkTaskbar" Type="System.Boolean" Scope="User">
-      <Value Profile="(Default)">True</Value>
-    </Setting>
     <Setting Name="RunOnStartup" Type="System.Boolean" Scope="User">
       <Value Profile="(Default)">True</Value>
     </Setting>