Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit version in bower.json cause an error #37

Open
AzaroQL opened this issue Feb 1, 2018 · 3 comments
Open

Explicit version in bower.json cause an error #37

AzaroQL opened this issue Feb 1, 2018 · 3 comments

Comments

@AzaroQL
Copy link

AzaroQL commented Feb 1, 2018

When i set version explicitly(1.0.1 or 1.0.x) i get an error on bower update, works with '*' tho.
Screenshot - http://puu.sh/zeiH1/ade3bb8b9a.png

@patorjk
Copy link
Owner

patorjk commented Feb 2, 2018

I've been looking into this, though I'm not sure what's causing it. Installing the latest version works, though trying to get a version by its version number leads to an error. However, you can still install by the commit number and it'll work that way (ex: "bower install d3-context-menu#9b9c146", from: https://github.com/patorjk/d3-context-menu/commits/master).

@espositocode
Copy link

espositocode commented Mar 9, 2018

I ran into this issue as well, since a change in d3-context-menu at some point broke compatibility with my code.

@patorjk I believe you are supposed to use git tags to version the repo. I noticed you don’t currently have any tags assigned, which is why you get the “tag not found” error when specifying “1.0.1” in bower.

@patorjk
Copy link
Owner

patorjk commented Mar 9, 2018

Looks like I can make tags by doing a "release" in the github interface. Honestly haven't done this before, so I'm going to read-up more on this tonight. Hopefully that will resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants