Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some issues around Xcode 9 yelling about using UIKit on background threads #152

Closed
wants to merge 1 commit into from

Conversation

rhaining
Copy link

In Xcode 9, the new main thread checker kept warning me about FastImageCache using UIApplication's isProtectedDataAvailable on a background thread. This should be innocuous, but I think Xcode 9 is just broadly looking at UIKit on background threads.

More consequently, this was preventing me from running unit tests locally on my own project.

The basic change here is to use NSNotificationCenter to watch for notifications when protected data becomes available or unavailable, and maintain that state as a static variable, which the instances can then utilize.

@rhaining
Copy link
Author

This also resolves this issue: #150

@RodBrown1988
Copy link

@rhaining After chatting with @mallorypaine on Twitter, he has left Path, and this repo no longer has anyone with write access actively working on it.

I'm looking at upgrading my personal version of it, and perhaps starting a canonical side fork now that Path seem to have abandoned this repo.

@rhaining
Copy link
Author

rhaining commented Sep 5, 2017

@RodBrown1988 dang! thanks for the heads-up.

@yoon-boom
Copy link

I guess can't find podspec, no maintenance (looks like they left path) only option is either fork-> create own branch then create your own podspec or manually hardcopy files is the only option.

@mallorypaine
Copy link
Contributor

Please open PRs against my fork here: https://github.com/mallorypaine/FastImageCache

I will continue to maintain FIC even though Path itself is no longer maintaining it.

@Sega-Zero
Copy link
Contributor

@rhaining, will you do this? I can make a PR if you don't have free time for it

@rhaining
Copy link
Author

@Sega-Zero this PR is ready to be merged

@Sega-Zero
Copy link
Contributor

@rhaining please, read the thread, @mallorypaine cannot merge it in this repo, we need a PR into a fork

@Sega-Zero
Copy link
Contributor

@mallorypaine is it possible to transfer this repo to you? Is there anyone in Path who can do it?

@mallorypaine
Copy link
Contributor

No idea. I don’t think there’s a single person left from when I was there.

@k-krzyszczak
Copy link

@rhaining ETA of new version with this merge?

@Sega-Zero
Copy link
Contributor

@Jeaday this has been merged in mallorypaine#1

@mallorypaine Is it possible to update the pod? Or maybe create a new one?

@rhaining
Copy link
Author

rhaining commented Dec 6, 2017

@Jeaday i don't work for Path or know anyone there. as far as i know, this project is unmaintained now. i have a fork over here https://github.com/rhaining/FastImageCache/ with those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants