Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing issues in migrated VPN profiles #1128

Open
keeshux opened this issue Jan 30, 2025 · 0 comments
Open

Routing issues in migrated VPN profiles #1128

keeshux opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
OpenVPN regression Used to work but doesn't anymore WireGuard
Milestone

Comments

@keeshux
Copy link
Member

keeshux commented Jan 30, 2025

Do not migrate v2 "Network settings" to a "Routing" module. They just are not the same.

In particular, when overriding the "Default gateway", v2 used to tweak in place:

  • The redirect-gateway flags in OpenVPN configurations (and this usually works)
  • The AllowedIPs directive in WireGuard configurations

The "Routing" module in v3 is doing a different thing, i.e. "include/exclude this route in/from the tunnel interface".

With WireGuard in particular, this is insufficient because the tunnel performs additional checks on allowed IP packets. E.g. if we include the default route with a "Routing" module, but the same route is not also present in AllowedIPs, this will happen:

IPv4 packet with disallowed source address from peer

and traffic will be dropped.

@keeshux keeshux self-assigned this Jan 30, 2025
@keeshux keeshux added the regression Used to work but doesn't anymore label Jan 30, 2025
@keeshux keeshux added this to the 3.1.0 / DNS milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenVPN regression Used to work but doesn't anymore WireGuard
Projects
None yet
Development

No branches or pull requests

1 participant