Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to delete action #1202

Open
ghost-from-the-past opened this issue Mar 14, 2021 · 2 comments
Open

unable to delete action #1202

ghost-from-the-past opened this issue Mar 14, 2021 · 2 comments
Labels
Bug needs-triage incoming, please sort

Comments

@ghost-from-the-past
Copy link

tested in the online demo
at System/System Preferences/Actions
in the action grid, one can add actions with the Add Action button and Save Action
the Delete Action button does not delete none of the existent actions

I tried to select the action row at all the fields/columns Entity or Action or Batch Job unsuccessfully
action_delete

@ghost-from-the-past ghost-from-the-past added Bug needs-triage incoming, please sort labels Mar 14, 2021
@ghost-from-the-past
Copy link
Author

ghost-from-the-past commented Mar 14, 2021

Seems that the source code is
/src/PartKeepr/FrontendBundle/Resources/public/js/Components/SystemPreferences/Preferences/ActionsConfiguration.js
there is a
handler: this.onAddAction
for the Add Action button
but no handler for the Delete Action button

Is there a "similar" code that I can use as example somewhere in the sources ? using it as "inspiration" to complete the missing code of the delete button

@ghost-from-the-past
Copy link
Author

ghost-from-the-past commented Mar 14, 2021

the fix appears in my pull request #1201

(warning this issue is 1202 and the pull request is 1201 what could create confusion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug needs-triage incoming, please sort
Projects
None yet
Development

No branches or pull requests

1 participant