fix: allow int and uint values in float type fields #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anirudh Chauhan <[email protected]>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
nitisht
added a commit
to parseablehq/.github
that referenced
this pull request
Nov 28, 2024
|
One of the unit tests is failing. Checking that |
|
I have opened a PR on your fork which will fix the test, performing test to validate our concerns |
|
@akshatagarwl we looked deeper into this issue and were able to figure out that for dynamic types we need to default to float for all numbers during ingestion itself. That will necessitate changes to this function: parseable/src/event/format/mod.rs Line 207 in 4af4e6c Please open a new PR, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989.
Description
allows int and uint values even when a field type is float
Using the same example mentioned in #989 (comment)
This PR has: