-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Server throws "User Does not have permission to access this" occasionally (arrow flight endpoint) #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
nitisht
added a commit
to parseablehq/.github
that referenced
this pull request
Jul 9, 2024
dharanad
commented
Jul 9, 2024
nikhilsinhaparseable
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #822
Description
When the parsable instance starts, it creates a session key for the admin user (of type
SessionKey::BasicAuth
) and adds it to the active session. This allows querying via Arrow Flight, as the session key is recognized as active.However, when the admin user logs in, the admin session key (of type
SessionKey::BasicAuth
) is removed from the active session and new admin session of typeSessionKey::SessionId
is added. Consequently, any subsequent queries by clients using Arrow Flight fail the authentication step because the handler create a session key of typeSessionKey::BasicAuth
and tries to lookup in the map which fails for obvious reasons.To address this, override permissions if the session key belongs to the user. This ensures that user sessions are maintained even if the admin logs in or logs out, preventing disruptions in client access via Arrow Flight.
Other Approach
SessionKey::BasicAuth
toSessionKey::SessionId
. If map get operation fails for typeBasicAuth
we retrived theSessionId
if exists and check if session id exists in active sessions.This PR has: