-
-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for visionOS #1762
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
@bmueller Thank you for the PR, everything looks good so far! Waiting for #1763 to be merged to fix the CI and to prevent any merge conflicts with this PR. The next steps would be:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 201 201
Lines 23233 23233
=======================================
+ Hits 14926 14927 +1
+ Misses 8307 8306 -1 ☔ View full report in Codecov by Sentry. |
@bmueller Would you want to add a visionOS job to the CI as well, so we can make sure it compiles? |
New Pull Request Checklist
Issue Description
Adds visionOS support.
Closes: #1761
Approach
Just added TARGET_OS_VISION in a bunch of places. Also updated the readme to mention visionOS alongside the other supported platforms.
TODOs before merging