notifications/libp2p: Terminate the outbound notification substream on std::io::Errors
#7724
+115
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stream Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
(unexpected eof) Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
commented
Feb 26, 2025
Comment on lines
+489
to
+493
| warn!( | ||
| target: "sub-libp2p", | ||
| "Error while reading from `NotificationsOutSubstream` peer={:?} error={error:?}", | ||
| this.peer_id | ||
| ); |
There was a problem hiding this comment.
I would make a release image and bake this PR in our stack for a bit. The Unexpected incoming data spuriously reproduced yesterday, I would like to gain a bit more data on this before downgrading the io::error warning into a debug
There was a problem hiding this comment.
These are programming errors and not something the operator can fix. These should be debug.
Signed-off-by: Alexandru Vasile <[email protected]>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
lexnv
changed the title
std::io::Errorsstd::io::Errors
Signed-off-by: Alexandru Vasile <[email protected]>
… into lexnv/substream-poll-unexpected
dmitry-markin
approved these changes
Feb 27, 2025
bkchr
reviewed
Feb 27, 2025
substrate/client/network/src/protocol/notifications/upgrade/notifications.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandru Vasile <[email protected]>
bkchr
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles a case where we called the
poll_nexton an outbound substream notification to check if the stream is closed. It is entirely possible that thepoll_nextwould return anio::error, for example end of file.This PR ensures that we make the distinction between unexpected incoming data, and error originated from
poll_next.While at it, the bulk of the PR change propagates the PeerID from the network behavior, through the notification handler, to the notification outbound stream for logging purposes.
cc @paritytech/networking
Part of: #7722