Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2503] Backport #7607 #7718

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link
Contributor

Backport #7607 into stable2503 from re-gius.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7607-to-stable2503
git worktree add --checkout .worktree/backport-7607-to-stable2503 backport-7607-to-stable2503
cd .worktree/backport-7607-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 3dc3a11cd68762c2e5feb0beba0b61f448c4fc92
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 25, 2025
@re-gius re-gius added the R0-silent Changes should not be mentioned in any release notes label Feb 25, 2025
@re-gius re-gius marked this pull request as ready for review February 25, 2025 17:34
@re-gius re-gius requested a review from a team as a code owner February 25, 2025 17:34
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@re-gius
Copy link
Contributor

re-gius commented Feb 25, 2025

This PR will be the "final" step for v16 metadata. Exposing this in 2503 will help gather feedback on v16 from the community to make it stable in the next stable release.

@re-gius re-gius requested a review from jsdw February 26, 2025 10:18
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am not super familiar with the backport rules here; the doc says to only backport fixes and not features, but not sure how strictly we adhere to this!

Getting this into a release would allow testing the "candidate" V16 metadata on live nodes sooner I guess, but people can build and test against the kitchensink runtime or polkadot master etc if backporting this isn't desirable.

@EgorPopelyaev EgorPopelyaev merged commit 64d4340 into stable2503 Feb 27, 2025
387 of 404 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7607-to-stable2503 branch February 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants