Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport/2412: Increase litep2p keep-alive to 10 seconds to mirror libp2p #7630

Merged
merged 1 commit into from
Feb 19, 2025
Merged

backport/2412: Increase litep2p keep-alive to 10 seconds to mirror libp2p #7630

merged 1 commit into from
Feb 19, 2025

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Feb 19, 2025

@lexnv
litep2p: Increase keep-alive to 10 seconds to mirror libp2p (#7488)
e4e4c7b 
This PR ensures that litep2p will keep an idle connection alive for 10
seconds.

The bump from 5 seconds is done to mirror the libp2p behavior and
potentially improve connection stability:

https://github.com/paritytech/polkadot-sdk/blob/a07fb323bc0cfb5c2fb4c8fbe9d20e344cc8eeaf/substrate/client/network/src/service.rs#L542-L549

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv self-assigned this Feb 19, 2025
@lexnv lexnv added the A3-backport Pull request is already reviewed well in another branch. label Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 5b297a0 into stable2412 Feb 19, 2025
180 of 236 checks passed
@EgorPopelyaev EgorPopelyaev deleted the lexnv/backport-timeout branch February 19, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees

@lexnv lexnv

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lexnv @ggwpez @niklasad1 @EgorPopelyaev