Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Runtime Api version to metadata #7607

Merged
merged 24 commits into from
Feb 25, 2025

Conversation

re-gius
Copy link
Contributor

@re-gius re-gius commented Feb 18, 2025

The runtime API implemented version is not explicitly shown in metadata, so here we add it to improve developer experience.
We need to bump frame-metadata and merkleized-metadata to allow this new feature.

This closes #7352 .

Refactor: also changing all the occurrences of ViewFunctionMethod to just ViewFunction for metadata types.

@re-gius re-gius self-assigned this Feb 18, 2025
@re-gius re-gius added the T4-runtime_API This PR/Issue is related to runtime APIs. label Feb 18, 2025
@re-gius
Copy link
Contributor Author

re-gius commented Feb 18, 2025

/cmd prdoc --audience runtime_dev --bump minor

@re-gius re-gius marked this pull request as ready for review February 21, 2025 17:05
@re-gius re-gius requested a review from a team as a code owner February 21, 2025 17:05
@re-gius re-gius requested a review from jsdw February 24, 2025 14:08
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13501831123
Failed job name: test-doc

Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@re-gius re-gius enabled auto-merge February 24, 2025 17:03
@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes and removed R0-silent Changes should not be mentioned in any release notes labels Feb 24, 2025
@re-gius re-gius disabled auto-merge February 24, 2025 18:37
@re-gius re-gius requested review from a team as code owners February 25, 2025 11:02
@re-gius re-gius added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit 3dc3a11 Feb 25, 2025
249 of 254 checks passed
@re-gius re-gius deleted the re-gius/runtime-api-metadata-version branch February 25, 2025 14:03
@re-gius re-gius added the A4-needs-backport Pull request must be backported to all maintained releases. label Feb 25, 2025
@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7607-to-stable2407
git worktree add --checkout .worktree/backport-7607-to-stable2407 backport-7607-to-stable2407
cd .worktree/backport-7607-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 3dc3a11cd68762c2e5feb0beba0b61f448c4fc92
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7607-to-stable2409
git worktree add --checkout .worktree/backport-7607-to-stable2409 backport-7607-to-stable2409
cd .worktree/backport-7607-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 3dc3a11cd68762c2e5feb0beba0b61f448c4fc92
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7607-to-stable2412
git worktree add --checkout .worktree/backport-7607-to-stable2412 backport-7607-to-stable2412
cd .worktree/backport-7607-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 3dc3a11cd68762c2e5feb0beba0b61f448c4fc92
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2503:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7607-to-stable2503
git worktree add --checkout .worktree/backport-7607-to-stable2503 backport-7607-to-stable2503
cd .worktree/backport-7607-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 3dc3a11cd68762c2e5feb0beba0b61f448c4fc92
git push --force-with-lease

EgorPopelyaev pushed a commit that referenced this pull request Feb 27, 2025
Backport #7607 into `stable2503` from re-gius.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Giuseppe Re <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T4-runtime_API This PR/Issue is related to runtime APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata V16: Add version number to Runtime API trait information
3 participants