omni-node: --dev sets manual seal and allows --chain to be set #6646
+96
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
added
T9-cumulus
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
changed the title
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
2 tasks
Signed-off-by: Iulian Barbu <[email protected]>
skunert
reviewed
Nov 27, 2024
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
skunert
approved these changes
Nov 28, 2024
| @@ -128,7 +128,8 @@ pub struct Cli<Config: CliConfig> { | |||
| /// | |||
| /// This is a dev option, and it won't result in starting or connecting to a parachain network. | |||
| /// The resulting node will work on its own, running the wasm blob and artificially producing | |||
| /// a block each `dev_block_time` ms, as if it was part of a parachain. | |||
| /// a block each `dev_block_time` ms, as if it was part of a parachain. Defaults to 3000ms if | |||
| /// not set and `--dev` is used. | |||
There was a problem hiding this comment.
I would be more explicit here about enabling manual sealing and fact that --dev enables this.
/// Start a dev node that produces a block each `dev_block_time` ms.
///
/// This is a dev option. It enables a manual sealing, meaning blocks are produced manually
/// rather than being part of an actual network consensus process. Using the option won't
/// result in starting or connecting to a parachain network. The resulting node will work on
/// its own, running the wasm blob and artificially producing a block each `dev_block_time` ms,
/// as if it was part of a parachain.
///
/// The `--dev` flag sets the `dev_block_time` to a default value of 3000ms unless explicitly provided.
There was a problem hiding this comment.
Used your phrasing here: d6faae7
| #[arg(long, conflicts_with_all = &["chain"])] | ||
| /// This flag sets `--chain=dev`, `--force-authoring`, `--rpc-cors=all`, `--alice`, and `--tmp` | ||
| /// flags, unless explicitly overridden. It also disables local peer discovery (see `--no-mdns` | ||
| /// and `--discover-local`). |
There was a problem hiding this comment.
Should we mention manual seal here? (I know it does not enable it for every node, but I think it would be good to have this information in cli).
There was a problem hiding this comment.
Added a note here: d6faae7.
Signed-off-by: Iulian Barbu <[email protected]>
Co-authored-by: Michal Kucharczyk <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few things:
--devflag will not conflict with--chainanymore, but if--chainis not given will set--chain=dev.--dev-block-timeis optional and it defaults to 3000ms if not set after setting--dev.--dev.Closes: #6537
Integration
Relevant for node/runtime developers that use OmniNode lib, including
polkadot-omni-nodebinary, although the recommended way for runtime development is to usechopsticks.Review Notes
parachain-template-nodeas is (meaning--devisn't usable and testing a runtime with theparachain-template-nodestill needs a relay chain here). I am doing this because I think we want either way to phase outparachain-template-nodeand adding manual seal support for it is wasted effort. We might add support though if the demand is forparachain-template-node.--dev-block-time. Also, would want first to align & merge on runtime metadata checks we added in Omni Node here: omni-node: add metadata checks for runtime/parachain compatibility #6450 before starting to infer AURA config slot duration via the same way.--devnow.