Include submitting origin in PollStatus #4961
Conversation
olanod
force-pushed
the
polling-ref-provides-origin
branch
from
3a90bfd to
8e23940
Compare
| @@ -59,9 +59,12 @@ impl pallet_balances::Config for Test { | |||
| type AccountStore = System; | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, PartialEq, Eq)] | |||
| pub struct Who; | |||
There was a problem hiding this comment.
Why not make the type generic over AccountId? This can later be T::AccountId
There was a problem hiding this comment.
The "who" is not relevant for conviction voting so in this tests I just added a simple struct as placeholder, this struct is not used in the actual implementation of Polling in pallet referenda where it's set as the runtime origin. Perhaps I don't get your point on why Who would need to accept a generic field or is it in the TestPollState where you suggest the generic parameter? anyway let me know to clarify :)
| None, | ||
| Ongoing(Tally, Class), | ||
| Ongoing(Tally, Class, Who), |
| @@ -85,6 +85,7 @@ pub trait Polling<Tally> { | |||
| type Index: Parameter + Member + Ord + PartialOrd + Copy + HasCompact + MaxEncodedLen; | |||
| type Votes: Parameter + Member + Ord + PartialOrd + Copy + HasCompact + MaxEncodedLen; | |||
| type Class: Parameter + Member + Ord + PartialOrd + MaxEncodedLen; | |||
| type Who; | |||
There was a problem hiding this comment.
Same.
Also while there is not yet docs, we should start :D Maybe add a doc explaining this.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
@olanod are you still interested in this or can we close it? |
olanod
force-pushed
the
polling-ref-provides-origin
branch
from
4750e01 to
f6b26e4
Compare
olanod
force-pushed
the
polling-ref-provides-origin
branch
from
f6b26e4 to
9a7c812
Compare
Sorry I forgot about the who->origin suggestion. It's still relevant! even more now that it seems iterable tracks will be merged and we won't need our own fork of the sdk :) |
olanod
force-pushed
the
polling-ref-provides-origin
branch
from
9a7c812 to
f50beaa
Compare
| Completed(Moment, bool), | ||
| } | ||
|
|
||
| impl<Tally, Moment, Class> PollStatus<Tally, Moment, Class> { | ||
| pub fn ensure_ongoing(self) -> Option<(Tally, Class)> { | ||
| impl<Tally, Moment, Class, Origin> PollStatus<Tally, Moment, Class, Origin> { |
There was a problem hiding this comment.
Actually thinking about this again, maybe we should introduce some DispatchablePollStatus: PollStatus that only gives you the origin.
There can be polls that are not dispatchables and then you would not have an Origin.
Adding a
Whoparameter to thePollStatus::Ongoingvariant is a simple change that provides more context to "pollsters" who might be interested in knowing what origin is going to execute a given call.