Prepare new candidate version: Add node feature #10472
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
force-pushed
the
rk-prep-new-candidate-version
branch
from
8c529fe to
1588d71
Compare
eskimor
force-pushed
the
rk-prep-new-candidate-version
branch
from
1588d71 to
21db3df
Compare
+ Fix a typo.
eskimor
force-pushed
the
rk-prep-new-candidate-version
branch
from
21db3df to
d66e38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a preparation PR for the actual functionality to ease reviews: Functionally nothing should change with this PR just yet, which is part why it seems sensible to make this a separate PR, double-checking exactly this: Functionality should stay unaffected by this PR - behavior would only change with the introduced node feature getting enabled.
To keep code a bit cleaner, I also got rid of v2 node feature handling, since it is enabled everywhere already.