Merge pull request #3926 from parca-dev/fix-scrape

brancz · web-flow · commit d2b3947b3518 · 2023-10-20T11:43:26.000+02:00
pkg/scrape: Fix scraping without executable info
diff --git a/pkg/scrape/scrape.go b/pkg/scrape/scrape.go
@@ -502,7 +502,7 @@ mainLoop:
 				continue
 			}
 
-			executableInfo := []*profilepb.ExecutableInfo{}
+			var executableInfo []*profilepb.ExecutableInfo
 			for _, comment := range p.Comments {
 				if strings.HasPrefix(comment, "executableInfo=") {
 					ei, err := parseExecutableInfo(comment)

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ mainLoop:`
`502`	`502`	`continue`
`503`	`503`	`}`
`504`	`504`
`505`		`- executableInfo := []*profilepb.ExecutableInfo{}`
	`505`	`+ var executableInfo []*profilepb.ExecutableInfo`
`506`	`506`	`for _, comment := range p.Comments {`
`507`	`507`	`if strings.HasPrefix(comment, "executableInfo=") {`
`508`	`508`	`ei, err := parseExecutableInfo(comment)`