Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Decoding Additional Features #56

Open
5 tasks
sslivkoff opened this issue Sep 1, 2023 · 3 comments
Open
5 tasks

Event Decoding Additional Features #56

sslivkoff opened this issue Sep 1, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sslivkoff
Copy link
Member

event decoding checklist

  • direct handling of u256 types
  • display columns from event decoding in the initial schema summary printed when cryo starts
  • ensure that consistent datatypes are used for decoded columns even when dataframe is empty

after those are complete:

  • enable fetching event abi's from etherscan for easier input specification of event types
  • add "json decoding mode" that decodes all event args as json
    • this will allow for decoding multiple event types in a single dataset
@007vasy
Copy link

007vasy commented Sep 4, 2023

the heimdall.rs repo have a quite nice recursive one for transactions:
https://github.com/Jon-Becker/heimdall-rs/blob/main/heimdall/src/decode/mod.rs#L65

the only thing missing as I see creating the JSON-likes structure with the names in the ABI

@007vasy
Copy link

007vasy commented Sep 4, 2023

@sslivkoff keep in mind that for event decoding there could be an event hash collision because:
event RandomEvent(indexed A, indexed B, indexed C)
has the same event hash as:

  • event RandomEvent(A, B, C)
  • event RandomEvent(indexed A, B, C)
  • event RandomEvent(indexed A, indexed B, C)

@007vasy
Copy link

007vasy commented Sep 4, 2023

@sslivkoff sslivkoff added the enhancement New feature or request label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants