Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Improve locale management #67

Open
panwauu opened this issue Aug 2, 2022 · 0 comments
Open

Refactor: Improve locale management #67

panwauu opened this issue Aug 2, 2022 · 0 comments
Labels
Type: Refactor Aesthetic changes Type: Test Issue regarding tests or code analysis

Comments

@panwauu
Copy link
Owner

panwauu commented Aug 2, 2022

Problems:

  1. Unused keys can happen
  2. It is hard to find the correct string in the (language).json file

We can tackle Problem 1 by:

  • eslint: disable dynamic keys
  • Refactor to remove all dynamic keys
  • vue-i18n-extract: to check for missing keys afterwards
  • Include in CI
@panwauu panwauu added Type: Test Issue regarding tests or code analysis Type: Refactor Aesthetic changes labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Refactor Aesthetic changes Type: Test Issue regarding tests or code analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@panwauu