Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements memoization using instance variables per method #246

Closed
wants to merge 1 commit into from
Closed

Implements memoization using instance variables per method #246

wants to merge 1 commit into from

Conversation

jemmaissroff
Copy link
Contributor

Resolves #243

Before merging:

  • Copy the table printed at the end of the latest benchmark results into the README.md and update this PR
  • If this change merits an update to CHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning

@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #246 (a48c638) into main (5581c30) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a48c638 differs from pull request most recent head ef0c5f4. Consider uploading reports for the commit ef0c5f4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          206       183   -23     
=========================================
- Hits           206       183   -23
Impacted Files Coverage Δ
lib/memo_wise.rb 100.00% <100.00%> (ø)
lib/memo_wise/internal_api.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5581c30...ef0c5f4. Read the comment docs.

@PikachuEXE
Copy link
Contributor

CI for 3.0 failed for Branch coverage (92.59%) is below the expected minimum coverage (100.00%).
But
https://codecov.io/github/panorama-ed/memo_wise/commit/4c549d4302e3164f8211e8f15cffe96ae5d2f7e9
shows 100%

I can't understand this 😅

@PikachuEXE
Copy link
Contributor

Oh wait there is code conflict

@jemmaissroff jemmaissroff force-pushed the instance-variables-per-method branch 2 times, most recently from 4b1c47d to c3e8cf5 Compare December 13, 2021 15:32
@jemmaissroff
Copy link
Contributor Author

Not planning on working on this in the immediate future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use method-specific instance variables for methods that take arguments
2 participants
@jemmaissroff @PikachuEXE