Skip to content

Conversation

@antznette1
Copy link

@antznette1 antznette1 commented Nov 12, 2025

Notes:

  • test_np_fix now uses [pytest.mark.xfail(condition=not](cci:4://file://pytest.mark.xfail(condition=not:0:0-0:0) is_numpy_dev, reason=...) without strict=True.
  • No runtime probing; minimal and idiomatic.

@jbrockmendel jbrockmendel added the AI Slop Suspected of being AI-generated, which is not welcome. label Nov 12, 2025
@antznette1 antznette1 closed this Nov 12, 2025
@antznette1 antznette1 deleted the tst/np-dev-xfail-np-fix branch November 12, 2025 23:40
@antznette1 antznette1 restored the tst/np-dev-xfail-np-fix branch November 12, 2025 23:50
@antznette1 antznette1 reopened this Nov 12, 2025
@jbrockmendel
Copy link
Member

Most of this PR is not doing what the description says. Did a human write this?

@antznette1 antznette1 force-pushed the tst/np-dev-xfail-np-fix branch from dbf5792 to ee22319 Compare November 13, 2025 21:31
@antznette1
Copy link
Author

Most of this PR is not doing what the description says. Did a human write this?

Most of this PR is not doing what the description says. Did a human write this?

Thanks for the review. I’ve reduced the PR to a single test change:
test_np_fix uses is_numpy_dev in the xfail marker (no strict, no runtime probing). The title & description now reflect the minimal scope. The intent is to avoid numpy-dev/python-dev XPASS(strict) failures while keeping behavior unchanged on non-dev builds. Happy to adjust if you prefer a different guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Slop Suspected of being AI-generated, which is not welcome.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants