Discard getServiceStatus logging to avoid log explosion (#61)

Querying the service status can happen any number of times between
service 'start's.  Since log truncating only happens on start, this
can cause unchecked growth of service loggers.

Author: cbrockington

init/cli/logging.go

@@ -17,6 +17,7 @@ package cli
 import (
 	"fmt"
 	"io"
+	"io/ioutil"
 	"os"
 
 	"github.com/pkg/errors"
@@ -78,3 +79,15 @@ func (f *FileLoggers) OpenFile(path string) (*os.File, error) {
 	}
 	return file, nil
 }
+
+var devNull = launchlib.NoopClosingWriter{Writer: ioutil.Discard}
+
+type DevNullLoggers struct{}
+
+func (d *DevNullLoggers) PrimaryLogger() (io.WriteCloser, error) {
+	return &devNull, nil
+}
+
+func (d *DevNullLoggers) SubProcessLogger(name string) launchlib.CreateLogger {
+	return d.PrimaryLogger
+}

init/cli/status.go

@@ -36,7 +36,8 @@ If exit code is nonzero, writes an error message to stderr and var/log/startup.l
 }
 
 func status(ctx cli.Context, loggers launchlib.ServiceLoggers) error {
-	serviceStatus, err := getServiceStatus(ctx, loggers)
+	// Executed with logging for errors, however we discard the verbose logging of getServiceStatus
+	serviceStatus, err := getServiceStatus(ctx, &DevNullLoggers{})
 	if err != nil {
 		return logErrorAndReturnWithExitCode(ctx, errors.Wrap(err, "failed to determine service status"), 4)
 	}