-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java/java-node/gradle-node
sample broken with JVM 21
#873
Comments
I think it is the source compatibility flag in the build.gradle file. It's set to 17, so Gradle is complaining because it's building with Java 21. Can you try bumping that to Java 21? We haven't bumped that example to use Java 21 yet, the instructions are still set to Java 17 (see README for that example), which indicates you should set |
Ah sorry, I wasn't looking at the README, I just noticed our build job failed on that sample when we upgraded bellsoft. RTFM 🤦🏻♂️. I changed
Which resulted in this error...
I then upgraded gradle in the
|
I haven't tried to get it running on Java 21/Gradle 8, but it sounds like the tasks that we have in that sample are not configured correctly under Gradle 8. I'd need to look into that more, or perhaps @anthonydahanne might know what needs changed there. We should probably remove the Gradle deprecated features as well so that we're positioned well for Gradle 9 too (there's a comment saying that we are not ready). |
Expected Behavior
The
java/java-node/gradle-node
sample should build out of the box.Current Behavior
The release of
paketo-buildpacks/bellsoft-liberica:v11.0.0
includes an upgrade ofBP_JVM_VERSION
from 17 to 21. This breaks thejava/java-node/gradle-node
sample.Possible Solution
I'm not sure why the change to JVM 21 would break this sample.
Steps to Reproduce
See below for the error when using bellsoft v11.0.0 with default JVM 21.
Motivations
The text was updated successfully, but these errors were encountered: