Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some comments #45

Open
set-soft opened this issue Sep 12, 2020 · 2 comments
Open

Some comments #45

set-soft opened this issue Sep 12, 2020 · 2 comments
Labels

Comments

@set-soft
Copy link

The theme looks really nice thanks!

I have some suggestions and questions. As this is the first time I run jekyll I'm not sure how useful they are ;-)

  1. In order to get jekyll working I had to add gem "kramdown-parser-gfm" to Gemfile. Without it I got messages saying kramdown-parser-gfm wasn't installed.

  2. The script/bootstrap script is designed to mess with the user system, instead of just install things in the user home. IMHO this is a very bad idea.

  3. I don't understand why the theme wastes so much user screen for screen sizes over tha 1060px. I also don't understand why so much sizes are hardcoded in pixels. As I said before I know nothing about jekyll, I just wanted to read images from my repo in an easy way when I found I had to use GitHub pages. So them I saw the templates and really liked this one. For my site I'm using:

section
{
 width:85%;
 right: -13%;
}
#banner
{
 right:1%;
 margin-right:0px;
 .fork
 {
  left:15%;
  margin-left:0;
 }
}
.wrapper
{
 width:95%
}
nav
{
 width: 14%;
 left:0;
 margin-left:0;
}
footer
{
 width: 14%;
 left:0;
 margin-left:0;
}
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@settings settings bot removed the wontfix label Jul 15, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant