Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish images to GitHub Container Registry #29

Open
6 of 11 tasks
YOU54F opened this issue Feb 8, 2024 · 5 comments
Open
6 of 11 tasks

Publish images to GitHub Container Registry #29

YOU54F opened this issue Feb 8, 2024 · 5 comments

Comments

@YOU54F
Copy link
Member

YOU54F commented Feb 8, 2024

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Mar 3, 2024

Using GitHub's container registry is great.

It would be good to document the change from an end-user perspective. If I used to docker run --rm pactfoundation/foo, what do I run now?

@YOU54F
Copy link
Member Author

YOU54F commented Mar 4, 2024

agree

docker pull ghcr.io/pact-foundation/pact-cli:latest
docker pull ghcr.io/pact-foundation/pact-broker:latest

the org changes from non hyphenated to hyphenated pact-foundation

a user may need to login to ghcr registry with their docker client

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

YOU54F referenced this issue in pact-foundation/pact-reference Mar 16, 2024
YOU54F added a commit to YOU54F/pact-stub-server that referenced this issue Apr 25, 2024
- create linux executables linked statically to musl
  - drop gnu (glibc) target, executable will work on alpine & glibc based distros (debian etc)
- create windows aarch64 target
  - required update to Cargo.lock to update ring to v0.17 due to build failures on v0.16
- refactor release script & workflow to match pact-reference
  - builds on pull request to master/main branch, in debug mode
- add Docker automated pipeline during release
  - publish multi-arch amd64/arm64
  - publish to DockerHub
  - publish to GitHub container registry

Related epics

- musl all the things
  - pact-foundation/roadmap#30
- publish to github container registry
  - pact-foundation/roadmap#29
YOU54F added a commit to pact-foundation/pact-stub-server that referenced this issue Apr 25, 2024
- create linux executables linked statically to musl
  - drop gnu (glibc) target, executable will work on alpine & glibc based distros (debian etc)
- create windows aarch64 target
  - required update to Cargo.lock to update ring to v0.17 due to build failures on v0.16
- refactor release script & workflow to match pact-reference
  - builds on pull request to master/main branch, in debug mode
- add Docker automated pipeline during release
  - publish multi-arch amd64/arm64
  - publish to DockerHub
  - publish to GitHub container registry

Related epics

- musl all the things
  - pact-foundation/roadmap#30
- publish to github container registry
  - pact-foundation/roadmap#29
@YOU54F
Copy link
Member Author

YOU54F commented May 10, 2024

Pact Stub Server

Now complete

DockerHub

docker pull pactfoundation/pact-stub-server
docker run -t -p 8080:8080 -v "$(pwd)/pacts/:/app/pacts" pactfoundation/pact-stub-server -p 8080 -d pacts

Github Container Registry

docker pull ghcr.io/pact-foundation/pact-stub-server
docker run -t -p 8080:8080 -v "$(pwd)/pacts/:/app/pacts" ghcr.io/pact-foundation/pact-stub-server -p 8080 -d pacts

@mjpieters
Copy link

Can this also be implemented for the pact-ref-verifier image from the pact-reference repository? I noticed that recent versions from that repo haven't been pushed to any registry (see pact-foundation/pact-reference#446).

@YOU54F
Copy link
Member Author

YOU54F commented Jun 20, 2024

yep sorry haven't got round to adding an auto publish to docker for the verifier and mock server cli. will look to get in place possibly next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants