Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

UpgradeKubeProxyAtLast can be true by default if this should be default behavior... #66

Open
github-actions bot opened this issue Jun 10, 2022 · 1 comment

Comments

@github-actions
Copy link

UpgradeKubeProxyAtLast can be true by default if this should be default behavior, needs more disscussions.

If this is true, kube-proxy will not be upgraded at first. See more details in kubernetes/kubeadm#2346

Then kube-proxy will be upgraded after all apiserver are upgraded.

+optional

// TODO UpgradeKubeProxyAtLast can be true by default if this should be default behavior, needs more disscussions.

	KubernetesVersion string `json:"kubernetesVersion"`

	// Local is used to determine whether to use local binary or download from internet.
	// +optional
	Local bool `json:"local,omitempty"`

	// UpgradeKubeProxyAtLast by default is false.
	// TODO UpgradeKubeProxyAtLast can be true by default if this should be default behavior, needs more disscussions.
	// If this is true, kube-proxy will not be upgraded at first. See more details in https://github.com/kubernetes/kubeadm/issues/2346
	// Then kube-proxy will be upgraded after all apiserver are upgraded.
	// +optional
	UpgradeKubeProxyAtLast bool `json:"upgradeKubeProxyAtLast,omitempty"`

	// INSERT ADDITIONAL SPEC FIELDS -
	// Important: Run "make" to regenerate code after modifying this file
}
ndex 2463d35..2d9532f 100644
++ b/api/v1alpha1/zz_generated.deepcopy.go

daab22c79e0b08b83f5360f367cd39278ec40794

@github-actions github-actions bot added the todo label Jun 10, 2022
@pacoxu
Copy link
Owner

pacoxu commented Jun 16, 2022

It can be considered once #68 is done.

@pacoxu pacoxu added this to the NEXT milestone Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant