Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation tests: make the time constraints more generous #15

Closed
TomasTomecek opened this issue May 25, 2022 · 6 comments
Closed

validation tests: make the time constraints more generous #15

TomasTomecek opened this issue May 25, 2022 · 6 comments
Assignees

Comments

@TomasTomecek
Copy link
Member

Last two days, two validation checks failed even though all GitHub check runs were green after some time:

https://github.com/packit/hello-world/runs/6587387284
https://sentry.io/share/issue/3d1ddfb488cd40eaae3550af18f15d00/
https://sentry.io/organizations/red-hat-0p/issues/3297006723/?referrer=alert_email&alert_type=email&alert_timestamp=1653371582691&alert_rule_id=855946&environment=production

Let's make the time limits more generous and aligned with our actual OKRs.

Example: check Basic test case: copr build and test (https://github.com/packit/hello-world/pull/648) failed: These check runs were not completed 20 minutes is too strict.

@stale
Copy link

stale bot commented Aug 14, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@TomasTomecek
Copy link
Member Author

I added this to the top of our jira backlog

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

1 similar comment
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@mfocko mfocko self-assigned this Oct 31, 2024
@mfocko mfocko transferred this issue from packit/deployment Oct 31, 2024
@mfocko mfocko moved this from backlog to in-progress in Packit Kanban Board Nov 6, 2024
@mfocko
Copy link
Member

mfocko commented Nov 6, 2024

Update on the issue

Currently we we're at 30 minutes… I see some failures in the Sentry, but it appears they are caused by the fact we have some deprecated targets in the PRs that we reuse (apparently got into pending sometime around branching and got stuck…) :/

mfocko added a commit to mfocko/validation that referenced this issue Nov 6, 2024
We're logging the contents of those constants and suffixing it with
“minutes”, yet... the constant »actually« holds seconds (given the usage
of ‹timedelta›). Therefore drop the multiples of ‹60› and use ‹minutes›
in the ‹timedelta› construction.

Related to packit#15

Signed-off-by: Matej Focko <[email protected]>
mfocko added a commit to mfocko/validation that referenced this issue Nov 6, 2024
We're logging the contents of those constants and suffixing it with
“minutes”, yet... the constant »actually« holds seconds (given the usage
of ‹timedelta›). Therefore drop the multiples of ‹60› and use ‹minutes›
in the ‹timedelta› construction.

Related to packit#15

Signed-off-by: Matej Focko <[email protected]>
mfocko added a commit to mfocko/validation that referenced this issue Nov 6, 2024
We're logging the contents of those constants and suffixing it with
“minutes”, yet... the constant »actually« holds seconds (given the usage
of ‹timedelta›). Therefore drop the multiples of ‹60› and use ‹minutes›
in the ‹timedelta› construction.

Related to packit#15

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko moved this from in-progress to in-review in Packit Kanban Board Nov 6, 2024
@mfocko
Copy link
Member

mfocko commented Nov 14, 2024

Based on the discussion on the architecture (a week ago), we agreed on keeping the current timeout and changing it further, if required. Therefore closing this issue as done, since the timeout has already changed from the reporting.

@mfocko mfocko closed this as completed Nov 14, 2024
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

2 participants