Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 'tmt_plan' and 'tf_post_install_script' #491

Closed
csomh opened this issue Jun 29, 2022 · 8 comments
Closed

Document 'tmt_plan' and 'tf_post_install_script' #491

csomh opened this issue Jun 29, 2022 · 8 comments

Comments

@csomh
Copy link
Contributor

csomh commented Jun 29, 2022

Was introduced in packit/packit#1619.

@TomasTomecek
Copy link
Member

ah, I just realized Rodolfo already resolved this in #489

pity he didn't link the docs PR with the p-s PR

@csomh
Copy link
Contributor Author

csomh commented Jul 1, 2022

Shouldn't we document everything on https://packit.dev/docs/configuration/, too? In order to have a single page where everything can be found in a single place.

@TomasTomecek
Copy link
Member

oh, I missed it's in the testing-farm document and not the configuration; agreed!

@TomasTomecek TomasTomecek reopened this Jul 1, 2022
@TomasTomecek
Copy link
Member

There are only links in configuration.md pointing to testing-farm. Do we want to keep this trend or actually have a single page with all the configuration values?

@csomh
Copy link
Contributor Author

csomh commented Jul 1, 2022

I'm not sure, but so far I found it handy to be able to open the configuration page and look up any configuration option.

As a user I would expect something like this, or if there are more options, then maybe multiple pages, but then it should be clear which page covers what. Right now I don't think it's self-explanatory that the "Testing Farm" page also documents configuration, or that the Configuration page doesn't document options related to Testing Farm.

@TomasTomecek
Copy link
Member

+1 I also grep mostly when looking for a config option

@lachmanfrantisek
Copy link
Member

Related to #467

@csomh
Copy link
Contributor Author

csomh commented Sep 6, 2022

Closing. #467 should fix this.

@csomh csomh closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2022
Repository owner moved this from backlog to done in Packit Kanban Board Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants