-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference test repository in the test job metadata #968
Comments
Hey @mrc0mmand 👋 This is definately the right project to file this issue and this is a good proposal. Let's see what the others say, but I'm all for implementing this... and shouldn't be that difficult either. |
I'd call it jobs:
- job: tests
trigger: pull_request
metadata:
targets:
- fedora-all
fmf_url: https://github.com/johnsmith/my-fabulous-tests
fmf_ref: main # optional, defaults to repo's default branch It should be as easy as putting this into TF request payload instead of the source repo url/ref. |
Looking at a possible implementation (so I could start playing with TFT in systemd) - wouldn't be necessary to extend the metadata-related classes in Packit as well? Like JobMetadataSchema and JobMetadataConfig. |
Add test repo reference to package-config This commit adds 'fmf_url' and 'fmf_ref' to JobMetadataConfig. This can be later used to store tests in different repository. Related To: packit/packit-service#968 Reviewed-by: Jiri Popelka <None> Reviewed-by: Tomas Tomecek <[email protected]>
Closed by packit/packit#1155, in case you feel the point of this issue was not fulfilled, please reopen |
I suspect this needs #1021 as well, so we can use it with PaaS? |
Allow to reference a test repo in test job metadata This change allows to specify distinct repository for tests. Fixes: #968 Reviewed-by: Jiri Popelka <None> Reviewed-by: Matej Mužila <None> Reviewed-by: Tomas Tomecek <[email protected]>
@mrc0mmand The change from #1021 has been deployed to the staging instance of the service. |
Thank you! I'll try to test it out as soon as I have some spare time on my hands (I already have the staging app enabled for my test repo, so it shouldn't be an issue). |
Hello!
Would it be possible to use the test job metadata to reference a repository which contains the whole FMF tree with tests to run? Something along these lines:
I know that currently you can reference a test repository using FMF, but even for this you need to have an initialized FMF tree in the repo plus the respective FMF file. Being able to reference the test repo directly in
packit.yml
would be way nicer, imo.I'm not sure if this RFE should be filed for Packit or TMT/TFT, so apologies if I chose the wrong project :-)
The text was updated successfully, but these errors were encountered: