Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/packit propose-downstream comment in a issue retriggers also non failed targets (and fails) #2714

Open
2 tasks
majamassarini opened this issue Feb 13, 2025 · 0 comments
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.

Comments

@majamassarini
Copy link
Member

majamassarini commented Feb 13, 2025

When retriggering propose-downstream from an issue, packit-service runs the propose-downstream on all the configured targets and not just for the one reported as failed.

On the non-failed targets the PRs were already merged and this caused packit-service to report an error for the already released targets.

We can:

  • re-run the propose-downstream only for the failed target when the retriggering comes from the packit-service generated issue.
  • handle this exception as a warning instead of an error and in general mark the task as skipped instead of failed (in this way we should avoid to report an error to the user).
@mfocko mfocko added kind/feature New feature or a request for enhancement. area/fedora Related to Fedora ecosystem impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. complexity/single-task Regular task, should be done within days. labels Feb 17, 2025
@mfocko mfocko moved this from new to backlog in Packit Kanban Board Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.
Projects
Status: backlog
Development

No branches or pull requests

2 participants