Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release syncing is being retried for all branches when it is not possible to download archive #2447

Open
lbarcziova opened this issue Jun 19, 2024 · 0 comments
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lbarcziova
Copy link
Member

Related code:

for model in sync_release_run_model.sync_release_targets:
model.set_status(status=SyncReleaseTargetStatus.retry)
self.sync_release_helper.report_status_to_all(
description=f"{self.job_name_for_reporting.capitalize()} is "
f"being retried because "
"we were not able yet to download the archive. ",
state=BaseCommitStatus.pending,
url="",
)
return TaskResults(
success=True, # do not create a Sentry issue
details={"msg": "Not able to download archive. Task will be retried."},
)

If it is not possible to download the archive at least for one of the branches, all the branches are being retried no matter whether they ran successfully (probably coming from the assumption that the source being download is the same for all branches). That results in confusing behaviour for branches where the syncing already went successfully - multiple rebases in the created PR.

Reported by @ljavorsk for https://src.fedoraproject.org/rpms/man-pages-l10n/pull-request/23#. In this case the Source is different for the branches (in one incorrectly formatted).

@mfocko mfocko added area/fedora Related to Fedora ecosystem impact/high This issue impacts multiple/lot of users. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working. complexity/single-task Regular task, should be done within days. and removed impact/high This issue impacts multiple/lot of users. labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Status: backlog
Development

No branches or pull requests

2 participants