Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement periodic cleanup of unused sidetags #2412

Open
3 tasks
nforro opened this issue Apr 30, 2024 · 0 comments
Open
3 tasks

Implement periodic cleanup of unused sidetags #2412

nforro opened this issue Apr 30, 2024 · 0 comments
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.

Comments

@nforro
Copy link
Member

nforro commented Apr 30, 2024 •
edited
Loading

In the ideal case, a Packit-created sidetag should be removed by Bodhi after submitting an update from it. However, that doesn't necessarily have to happen for various reasons and we don't want useless sidetags to be piling up and wasting resources.

TODO:

  • in periodic intervals go through all side tags in sidetags table
  • if a sidetag doesn't contain any builds (koji list-tagged) or if it was created more than N weeks ago, remove it both from Koji (KojiHelper.remove_sidetag()) and from the sidetags table
  • document this
@nforro nforro mentioned this issue Apr 30, 2024
Open
@lachmanfrantisek lachmanfrantisek added kind/feature New feature or a request for enhancement. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Apr 30, 2024
@nforro nforro mentioned this issue Jul 26, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Jul 29, 2024
@softwarefactory-project-zuul
Implement koji_build trigger for bodhi_update job (#2475)
2103bec 
Implement `koji_build` trigger for `bodhi_update` job

Fixes #2379.
I purposefully didn't implement removing sidetags from DB after a successful update creation because I want to see first how exactly the Bodhi workflow works - at which point is the sidetag removed from Koji etc. Maybe it would be enough to leave it to the periodic cleanup: #2412

Reviewed-by: Laura Barcziová
@nforro nforro mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.
Projects
Packit Kanban Board
Status: priority-backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nforro @lachmanfrantisek