Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify maintainers about problems with Bodhi update #2404

Open
lachmanfrantisek opened this issue Apr 17, 2024 · 5 comments
Open

Notify maintainers about problems with Bodhi update #2404

lachmanfrantisek opened this issue Apr 17, 2024 · 5 comments
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.

Comments

@lachmanfrantisek
Copy link
Member

During discussions with the Gnome maintainers (https://github.com/packit/user/issues/18), a feature request appeared to be able to notify package maintainers about situations that require the maintainer's attention, e.g. negative karma, check failed,... but not about "normal" state like update created or positive karma added.

Alternative ideas:

  • Fedora notifications
  • Since this might be a generic feature for any Bodhi user, we can think about the possibility of rather doing this in Bodhi itself.

UX:

Implementation:

  • This would require parsing new types of messages and a new handler.
@lbarcziova
Copy link
Member

Since this might be a generic feature for any Bodhi user, we can think about the possibility of rather doing this in Bodhi itself.

I would probably lean towards this option as it seems more natural to have it there to me.

@lbarcziova lbarcziova added kind/feature New feature or a request for enhancement. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Apr 18, 2024
@lachmanfrantisek
Copy link
Member Author

Asking for opinion/help on Bodhi side: fedora-infra/bodhi#5644

@nforro
Copy link
Member

nforro commented Jul 2, 2024

  • There is a topic filtering available, but I am not sure if Bodhi sends negative karma comments to another topic.

Karma updates are still comments, so org.fedoraproject.prod.bodhi.update.comment works, e.g. negative karma for libarchive-3.7.2-5.fc40.

@ljavorsk
Copy link

ljavorsk commented Jul 2, 2024

Karma updates are still comments, so org.fedoraproject.prod.bodhi.update.comment works, e.g. negative karma for libarchive-3.7.2-5.fc40.

I didn't get any notification about negative karma on my package, which I didn't even think could happen, so if I hadn't been notified by @lachmanfrantisek I would not have noticed it for quite some time.

An issue_repository config option might be used.

Not sure about this option as some packages don't even configure this option. If you decide to use it, it should be heavily documented in your onboarding docs (so maintainers don't miss it). But I would rather see a regular Bodhi notification email, as I would expect from a regular update I create manually.

@kparal
Copy link

kparal commented Jul 3, 2024

I included some examples of where this might cause problems in packit/packit#2342 .

I'd also like to add that even some neutral comments might have content that the maintainer should see, perhaps a question or a concern, when the user is not sure whether it's a bug or not. One option could be if Bodhi implemented a "ping maintainer" checkbox when submitting feedback. Another option is to notify the maintainer (from packit side) also for neutral (and not just negative) comments. Or, for all comments (which is the current Bodhi behavior for manually created updates). Any solution would be an improvement over the current status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.
Projects
Status: backlog
Development

No branches or pull requests

5 participants