Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible race condition: target branch change after PR creation isn't being accounted for #2403

Open
2 tasks
lsm5 opened this issue Apr 15, 2024 · 1 comment
Open
2 tasks
Labels
area/copr Related to the integration with copr.fedorainfracloud.org/ complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lsm5
Copy link

lsm5 commented Apr 15, 2024

What happened? What is the problem?

See: containers/skopeo#2285 . The PR was initially created with the target branch as main which was later changed to release-1.13. The copr build jobs failed as packit was trying to merge the PR into the upstream main branch as set at the time of PR creation.

I guess the workaround would be to just submit a new PR with the correct branch from the get-go.

What did you expect to happen?

  • Packit should use the latest / current branch for jobs and not the branch at PR creation time.
  • Even better if copr builds and other jobs can be auto-retriggered on branch change.

Example URL(s)

See PR in description.

Steps to reproduce

1. create PR
2. change branch
3. retrigger copr jobs (maybe)

What is the impacted category (job)?

Copr builds

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@lsm5 lsm5 added the kind/bug Something isn't working. label Apr 15, 2024
@lsm5
Copy link
Author

lsm5 commented Apr 15, 2024

This seems to be a rare race. Also, containers/skopeo#2296 earlier mentioned in description is not actually an example of this bug as initially suspected, so I removed it from description.

In the PR referenced in description, the branch was changed right away after PR creation containers/skopeo#2285 (comment) and I'm unable to reproduce that on containers/skopeo#2299 . But maybe that helps to tighten constraints further.

@lsm5 lsm5 changed the title target branch change after PR creation isn't being accounted for possible race condition: target branch change after PR creation isn't being accounted for Apr 15, 2024
@lbarcziova lbarcziova added area/copr Related to the integration with copr.fedorainfracloud.org/ complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/copr Related to the integration with copr.fedorainfracloud.org/ complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Status: backlog
Development

No branches or pull requests

2 participants