Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please reduce the amount of comment packit sends to src.fp.o Pull Requests #2230

Closed
1 of 2 tasks
hroncok opened this issue Feb 9, 2024 · 2 comments · Fixed by packit/packit-service#2373
Closed
1 of 2 tasks

Please reduce the amount of comment packit sends to src.fp.o Pull Requests #2230

hroncok opened this issue Feb 9, 2024 · 2 comments · Fixed by packit/packit-service#2373
Assignees
@lbarcziova
Labels
area/fedora Related to Fedora ecosystem area/user-experience Usability issue complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/other Other kind than the specified ones.

Comments

@hroncok
Copy link
Contributor

hroncok commented Feb 9, 2024 •
edited
Loading

What happened? What is the problem?

In January, I received 69 emails from src.fp.o generated by the packet user.
In December it was 110.

As more and more packagers embrace packit, I get more and more emails (mostly from packages co-maintained by python-packagers-sig).

Every Pull Request opened by packit almost immediately receives a comment by packit, doubling the amount of email notifications.

Please consider folding the initial comment to the PR description.

Thanks.

What did you expect to happen?

No immediate comments by packit on packit PRs.

Example URL(s)

https://src.fedoraproject.org/rpms/python-PyGithub/pull-request/26#comment-181891

Steps to reproduce

1. Be subscribed to notifications for many packages that use packit.
2. Receive hundreds of email from src.fp.o by packit.
3. Miss important email from PRs opened by humans because they are easy to miss.

Workaround

  • There is an existing workaround that can be used until this issue is fixed. (Setup an email filter to delete the email from [email protected] when it matches "Logs and details of the syncing".)

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@lbarcziova
Copy link
Member

hi @hroncok !

Thank you for bringing up this issue. Regarding the decision to create a dedicated comment for each syncing, our intention was to maintain transparency, considering that a retriggered sync has a new dashboard link. This approach ensures that each comment corresponds to a specific run and shows the time of it, making it easier to trace the history of syncs.

But I understand the issue regarding the potential noise it creates. We could change the behaviour to include the link in the PR description and for retriggers overwrite it or just provide list of links (or creating the additional comments only for retriggered syncs?)

We will discuss this with the team on Monday and provide an update here.

@lbarcziova lbarcziova added the area/fedora Related to Fedora ecosystem label Feb 9, 2024
@hroncok
Copy link
Contributor Author

hroncok commented Feb 9, 2024

Comments for retriggers are probably fine. They provide valuable feedback that it happened. I only suggest to fold the firts comment to the pr description.

@lachmanfrantisek lachmanfrantisek added area/user-experience Usability issue complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/other Other kind than the specified ones. labels Feb 12, 2024
@lbarcziova lbarcziova self-assigned this Mar 12, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Mar 13, 2024
@lbarcziova
Don't comment about logs on just submitted sync PR
3fd1b3b 
Fixes packit/packit#2230
@lbarcziova lbarcziova mentioned this issue Mar 13, 2024
Merged
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Mar 15, 2024
@lbarcziova
Don't comment about logs on just submitted sync PR
ae8178b 
Fixes packit/packit#2230
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Mar 15, 2024
@lbarcziova
Don't comment about logs on just submitted sync PR
c37c2d3 
Fixes packit/packit#2230
@lbarcziova lbarcziova added the blocked We are blocked! label Mar 22, 2024
@lbarcziova lbarcziova removed the blocked We are blocked! label Jul 1, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 1, 2024
@lbarcziova
Don't comment about logs on just submitted sync PR
729d137 
Fixes packit/packit#2230
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 10, 2024
@lbarcziova
Don't comment about logs on just submitted sync PR
3567b01 
Fixes packit/packit#2230
softwarefactory-project-zuul bot added a commit to packit/packit-service that referenced this issue Jul 10, 2024
@softwarefactory-project-zuul
Don't comment about logs on just submitted sync PR (#2373)
9c3787d 
Don't comment about logs on just submitted sync PR

Fixes packit/packit#2230
RELEASE NOTES BEGIN
We have adjusted commenting behaviour regarding Packit logs on release syncing PRs.
RELEASE NOTES END

Reviewed-by: Maja Massarini
Reviewed-by: Laura Barcziová
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/fedora Related to Fedora ecosystem area/user-experience Usability issue complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/other Other kind than the specified ones.
Projects
Packit Kanban Board
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't comment about logs on just submitted sync PR lbarcziova/packit-service
3 participants
@hroncok @lachmanfrantisek @lbarcziova