Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.1 #301

Open
davethemodderguy opened this issue Jul 3, 2024 · 13 comments
Open

Update to 1.20.1 #301

davethemodderguy opened this issue Jul 3, 2024 · 13 comments

Comments

@davethemodderguy
Copy link

This thing is a total masterpiece please don't say you just gonna let it here and hit the dust for like 10 years

@Panthr75
Copy link

I am in the process of porting to 1.20.1. If anyone wants to help with textures, that would be greatly appreciated

@davethemodderguy
Copy link
Author

davethemodderguy commented Aug 20, 2024 via email

@Panthr75
Copy link

Once my project is able to compile, I'll set up a github for it.
image

Screenshots of the ammo press:
image

image

@Panthr75
Copy link

Still debating how to go about this due to the licensing. I could fork this repo, delete everything and add my changes, and make a pull request, but that's probably not the best solution.

It doesn't help that this project doesn't compile as is due to ftb-lib's maven repo getting taken down for 1.12.2

I saw that the author was working on a 1.18 fabric port, but it hasn't been updated in ~a year.

If @pWn3d1337 can help for clarity, that would be greatly appreciated.

@pWn3d1337
Copy link
Owner

I'm ok with having a 1.20 branch in this repo. I'm also willing to help out, I just don't have the time to handle the whole port by myself.
Do you already have some progress? Because porting Techguns is an insane amount of work, don't underestimate it.

@Panthr75
Copy link

@pWn3d1337 Yes I do have some progress, as seen by that ammo press screenshots. As stated above, once I get the project in a compileable state, I'll make a draft pull request, so you can comment on the state of the code.

I've tried to retain as much of the original mods functionality as possible, but I did change

  • the process on how titanium is aquired. Due to the whole ore dropping raw variant and smelting that, Titanium will drop Raw Ore and you'd process that into titanium chunks
  • all machines now accept a processing time in their recipe (except for the charging station)
  • ammo is more dynamic to allow for other mods to add their own guns and ammo with ammo variants

I've also set the project up with data generation. I saw that you somewhat have done this in your code but with forge 1.20 we have a separate gradle run to run data generation.

While you are here, do you have any suggestions for new textures/model changes?

Thank you for your reply.

@Panthr75
Copy link

Alright got rid of all of the compiler errors. Will you make a branch I can make a PR to?

@pWn3d1337
Copy link
Owner

pWn3d1337 commented Sep 9, 2024

@Panthr75
Copy link

Panthr75 commented Sep 9, 2024

@pWn3d1337 pull request has been made

@Danmccool
Copy link

@Panthr75 Can You Try And Build The Mod I Want to Test It on 1.20.1

@Panthr75
Copy link

@Danmccool As stated in the PR, the port isn't feature complete especially with models and guns aren't fully implemented yet. I'll probably make some more pull requests in my free time to update the 1.20.1 branch

@Danmccool
Copy link

Danmccool commented Sep 17, 2024

@Panthr75 Sounds Good

@augustinde
Copy link

augustinde commented Oct 26, 2024

@Panthr75 Hello, do you have any news about the 1.20.1 port?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants