addressing review comments

p4lang · Sep 11, 2023 · 03370e3 · 03370e3
1 parent 31d2064
commit 03370e3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/include/tdi/common/c_frontend/tdi_operations.h b/include/tdi/common/c_frontend/tdi_operations.h
@@ -28,7 +28,7 @@ tdi_status_t tdi_operations_set_value(tdi_operations_hdl *operations,
                                       tdi_operations_field_type_e type,
                                       const uint64_t value);
 
-tdi_status_t tdi_operations_get_value(tdi_operations_hdl operations,
+tdi_status_t tdi_operations_get_value(const tdi_operations_hdl *operations,
                                       tdi_operations_field_type_e type,
                                       uint64_t *value);
 

diff --git a/include/tdi/common/c_frontend/tdi_table.h b/include/tdi/common/c_frontend/tdi_table.h
@@ -26,7 +26,6 @@
 #include <tdi/common/c_frontend/tdi_table_data.h>
 #include <tdi/common/c_frontend/tdi_table_key.h>
 #include <tdi/common/tdi_defs.h>
-// #include <tdi/common/tdi_notifications.hpp>
 
 #ifdef __cplusplus
 extern "C" {
@@ -784,11 +783,12 @@ tdi_status_t tdi_operations_deallocate(tdi_operations_hdl *tbl_op_hdl);
  * @return Status of the API call
  */
 tdi_status_t tdi_operations_execute(const tdi_table_hdl *table_hdl,
-                                          const tdi_target_hdl *target,
-                                          const tdi_operations_hdl *tbl_ops);
+                                    const tdi_target_hdl *target,
+                                    const tdi_operations_hdl *tbl_ops);
 
 tdi_status_t tdi_notifications_registration_params_allocate(
-    const tdi_table_hdl *table_hdl, const tdi_id_t notification_id,
+    const tdi_table_hdl *table_hdl,
+    const tdi_id_t notification_id,
     tdi_notification_param_hdl **tbl_notification_hdl);
 
 tdi_status_t tdi_notifications_registration_params_deallocate(

diff --git a/include/tdi/common/c_frontend/tdi_table_info.h b/include/tdi/common/c_frontend/tdi_table_info.h
@@ -899,16 +899,14 @@ tdi_status_t tdi_table_operations_supported(
     tdi_operations_type_e *operations,
     uint32_t *num_returned);
 
-
 tdi_status_t tdi_table_num_notifications_supported(
     const tdi_table_info_hdl *table_info_hdl, uint32_t *num);
 
 tdi_status_t tdi_table_notifications_supported(
     const tdi_table_info_hdl *table_info_hdl,
-    // tdi_notifications_type_e *notifications,
     const char *notifications[],
     uint32_t *num_returned);
- 
+
 /**
  * @brief Get size of list of tables that the given table is dependent on
  *