Remove description length limit

Author: p1ass

export_test.go

@@ -2,5 +2,3 @@ package feeder
 
 var ExportItemConvert = (*Item).convert
 var ExportFeedConvert = (*Feed).convert
-
-var ExportItemsLimitDescription = (*Items).limitDescription

feeder.go

@@ -2,7 +2,6 @@ package feeder
 
 import (
 	ogp "github.com/otiai10/opengraph"
-	"golang.org/x/exp/utf8string"
 	"log"
 	"sync"
 	"time"
@@ -87,24 +86,11 @@ func Crawl(fetchers ...Fetcher) *Items {
 	}
 	wg.Wait()
 
-	items.limitDescription(200)
-
 	fetchOGP(items)
 
 	return items
 }
 
-func (items *Items) limitDescription(limit int) {
-	for _, i := range items.Items {
-		length := utf8string.NewString(i.Description).RuneCount()
-		maxLength := limit
-		if length < limit {
-			maxLength = length
-		}
-		i.Description = utf8string.NewString(i.Description).Slice(0, maxLength)
-	}
-}
-
 func fetchOGP(items *Items) *Items {
 	wg := sync.WaitGroup{}
 

feeder_test.go

@@ -1,15 +1,12 @@
 package feeder_test
 
 import (
+	"github.com/kr/pretty"
+	"github.com/naoki-kishi/feeder"
 	"reflect"
 	"strconv"
-	"strings"
 	"testing"
 	"time"
-	"unicode/utf8"
-
-	"github.com/kr/pretty"
-	"github.com/naoki-kishi/feeder"
 )
 
 type mockFetcher struct {
@@ -96,40 +93,3 @@ func TestCrawl(t *testing.T) {
 
 	}
 }
-
-func TestItems_limitDescription(t *testing.T) {
-	type fields struct {
-		Items []*feeder.Item
-	}
-	type args struct {
-		limit int
-	}
-	tests := []struct {
-		name   string
-		fields fields
-		args   args
-	}{
-		{
-			name: "longer than limit",
-			fields: fields{Items: []*feeder.Item{
-				{Description: strings.Repeat("a", 300)},
-			}},
-			args: args{limit: 200},
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			items := &feeder.Items{
-				Items: tt.fields.Items,
-			}
-			feeder.ExportItemsLimitDescription(items, tt.args.limit)
-
-			for _, i := range items.Items {
-				got := utf8.RuneCountInString(i.Description)
-				if tt.args.limit < got {
-					t.Errorf("Exceed string length limit. limit=%d got=%d", tt.args.limit, got)
-				}
-			}
-		})
-	}
-}

go.mod

@@ -10,5 +10,5 @@ require (
 	github.com/otiai10/opengraph v1.0.0
 	github.com/pkg/errors v0.8.1
 	github.com/stretchr/testify v1.3.0 // indirect
-	golang.org/x/exp v0.0.0-20190316020145-860388717186
+	golang.org/x/net v0.0.0-20190311183353-d8887717615a // indirect
 )

go.sum

@@ -1,6 +1,5 @@
 bou.ke/monkey v1.0.1 h1:zEMLInw9xvNakzUUPjfS4Ds6jYPqCFx3m7bRmG5NH2U=
 bou.ke/monkey v1.0.1/go.mod h1:FgHuK96Rv2Nlf+0u1OOVDpCMdsWyOFmeeketDHE7LIg=
-github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
 github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/kr/pretty v0.1.0 h1:L/CwN0zerZDmRFUapSPitk6f+Q3+0za1rQkzVuMiMFI=
@@ -26,13 +25,7 @@ github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+
 github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
-golang.org/x/exp v0.0.0-20190316020145-860388717186 h1:WVLLpyUE5WfDFkoRe+vPPFxVzwDwXwwG197QU7doL0M=
-golang.org/x/exp v0.0.0-20190316020145-860388717186/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
-golang.org/x/image v0.0.0-20190227222117-0694c2d4d067/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js=
-golang.org/x/mobile v0.0.0-20190312151609-d3739f865fa6/go.mod h1:z+o9i4GpDbdi3rU15maQ/Ox0txvL9dWGYEHz965HBQE=
 golang.org/x/net v0.0.0-20190311183353-d8887717615a h1:oWX7TPOiFAMXLq8o0ikBYfCJVlRHBcsciT5bXOrH628=
 golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
-golang.org/x/sys v0.0.0-20190312061237-fead79001313/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
-golang.org/x/tools v0.0.0-20190312151545-0bb0c0a6e846/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=