Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt types compatibility #16

Open
ntfshard opened this issue Nov 4, 2020 · 5 comments
Open

qt types compatibility #16

ntfshard opened this issue Nov 4, 2020 · 5 comments

Comments

@ntfshard
Copy link

ntfshard commented Nov 4, 2020

Hello

Is it make sense to prepare pull request with Qt types support? (or at least try to do it)
I believe sfinae magic should be enough for this.
Or library should be stl compatible only? Asking just for saving our time)

@sonulohani
Copy link

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

@ntfshard
Copy link
Author

ntfshard commented Jan 31, 2021

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

Yep, but it doesn't look elegant. To open file may be it's fine to use toStdString method. It will be called only once.
But you can't call cell.read_value(qstringobject), you should use std::string and copy value to qString
Moreover I noticed some weird issues with non-ascii symbols in patch -- it leads to crash.
And one more, it looks like implementation not satisfy rfc4180 5.2

@sonulohani
Copy link

sonulohani commented Feb 1, 2021

I dont know if the devs are even active here. We can have the fork of this repo to work on the bugs.

@ntfshard
Copy link
Author

ntfshard commented Feb 1, 2021

Or use other from fffaraz/awesome-cpp#csv repo

@sonulohani
Copy link

Or use other from fffaraz/awesome-cpp#csv repo

You could use other. But their could be subtle difference between these libraries. For fast parsing, csv2 is the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants