Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the responsibility of initialising oximeter schema clearer #7488

Open
karencfv opened this issue Feb 6, 2025 · 0 comments
Open

Make the responsibility of initialising oximeter schema clearer #7488

karencfv opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@karencfv
Copy link
Contributor

karencfv commented Feb 6, 2025

Initially, oximeter was in charge of creating the oximeter database and all of its tables. With the introduction of clickhouse-admin, the responsibility now falls on reconfigurator to call clickhouse-admin and initialise the schema.

When the introduction of clickhouse-admin happened, none of the code in oximeter was touched so it still contains code to initialise the schema. It's not a problem because the operation is idempotent, but it is no longer very clear whose responsibility it is to create the database/schema.

Related: #7454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant