Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstairs.rs test reconcile_not_ready works for the wrong reasons #1596

Open
leftwo opened this issue Jan 10, 2025 · 2 comments
Open

upstairs.rs test reconcile_not_ready works for the wrong reasons #1596

leftwo opened this issue Jan 10, 2025 · 2 comments

Comments

@leftwo
Copy link
Contributor

leftwo commented Jan 10, 2025

The test in upstairs/src/upstairs.rs reconcile_not_ready() tries to verify connect_region_set() will return false when there are only 2/3 downstairs in the proper state. The call to connect_region_set() actually fails because the upstairs is not in the proper state, so the test is not testing what it thinks it is.

The fix is just to move the upstairs to the proper state:

    let (_rx, done) = BlockOpWaiter::pair();
    up.state = UpstairsState::GoActive(done);

Before the call to connect_region_set()

@leftwo
Copy link
Contributor Author

leftwo commented Jan 10, 2025

There are a few othere tests in this area that might need the same treatment.

@leftwo
Copy link
Contributor Author

leftwo commented Jan 17, 2025

Fix as part of #1608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant