Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycle 2024.4: Parent-child relationships #3766

Closed
10 tasks done
Tracked by #3041
sophiamersmann opened this issue Jul 3, 2024 · 0 comments
Closed
10 tasks done
Tracked by #3041

Cycle 2024.4: Parent-child relationships #3766

sophiamersmann opened this issue Jul 3, 2024 · 0 comments
Assignees
@sophiamersmann

Comments

@sophiamersmann
Copy link
Member

sophiamersmann commented Jul 3, 2024 •
edited
Loading

Implementation plan

  • Add a table for chart configs, using UUIDs as primary key
    • Populate chart_configs.fullConfig for all existing charts
  • Add the default config to the database that every chart inherits from
    • Populate chart_configs.patchConfig for all existing charts
    • Update the admin API to handle inheritance from the default config
  • Add indicator charts and implement implicit inheritance
    • Point variables.grapherConfigETL and variables.grapherConfigAdmin to a row in the charts_config table
    • Update the admin API to handle implicit inheritance from indicator charts
    • Check all existing charts [2d]
  • Make the chart editor work with inheritance [2d]

Follow-up work: #3857

PRs to be merged when adding a chart_configs table:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophiamersmann sophiamersmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophiamersmann