Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant grapher steps #3202

Open
Marigold opened this issue Aug 26, 2024 · 2 comments
Open

Remove redundant grapher steps #3202

Marigold opened this issue Aug 26, 2024 · 2 comments
Labels
priority 3 - nice to have wontfix This will not be worked on

Comments

@Marigold
Copy link
Collaborator

Most of our grapher steps are just propagating the same dataset to the grapher channel. It's not a big deal, but it's one more dataset to store and maintain. We had some ideas for simplification:

  1. Instead of
grapher://grapher/namespace/version/dataset:
  - data://grapher/namespace/version/dataset
  
data://grapher/namespace/version/dataset
  - data://garden/namespace/version/dataset

simply build grapher from garden dataset

grapher://grapher/namespace/version/dataset:
  - data://garden/namespace/version/dataset
  1. If there's a YAML file in step directory without *.py file, take the garden dataset and enhance it with the YAML file
@pabloarosado
Copy link
Contributor

Not clear what the improvement is (in terms of code or data reduction). It may not be worth the effort.

Copy link

stale bot commented Nov 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 3 - nice to have wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants