Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Scheduled PR merges #2822

Open
spoonerf opened this issue Jun 17, 2024 · 6 comments
Open

Feature request: Scheduled PR merges #2822

spoonerf opened this issue Jun 17, 2024 · 6 comments

Comments

@spoonerf
Copy link
Contributor

Sometimes, it would be nice to schedule large PRs to merge overnight when no one is working.

PRs that involve large datasets can often block up the etl for a few hours, which can be problematic for others trying to work.

It looks like there are some ways to do it, described here.

@Marigold
Copy link
Collaborator

Marigold commented Jun 18, 2024

+1! And +100 for finding the tool to do it. I thought we'd have to do it ourselves.

We should make sure that it only merges if CI is ✅ . It's possible that someone changes a chart in prod and chart-diff would start failing.

@larsyencken
Copy link
Collaborator

Looks like Lucas already merged something here:

We should check that, and maybe replace it.

Copy link

stale bot commented Sep 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 11, 2024
@Marigold
Copy link
Collaborator

ETL became much faster & robust since we opened this issue. It should be pretty safe to merge in the middle of the day now. It should take less than hour.

@stale stale bot closed this as completed Sep 18, 2024
@lucasrodes lucasrodes reopened this Sep 19, 2024
@stale stale bot removed the wontfix This will not be worked on label Sep 19, 2024
@Marigold
Copy link
Collaborator

ETL became much faster & robust since we opened this issue. It should be pretty safe to merge in the middle of the day now. It should take less than hour.

@lucasrodes there are more ETL performance improvements on the way. I think we can get to a point where merging anytime is not a big deal, and we wouldn't need this. (Rebuilding full ETL takes ~1 hour now and could be sped up by using PREFER_DOWNLOAD=1 if you have a good connection)

@lucasrodes
Copy link
Member

lucasrodes commented Sep 19, 2024

yeah, that makes total sense! thanks for doing that

I would still like to explore this whenever I have some time, and have it be an option.

but based on earlier discussions, and all the performance improvements this a nice to have, and I shouldn't stress much about it :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants