-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Scheduled PR merges #2822
Comments
+1! And +100 for finding the tool to do it. I thought we'd have to do it ourselves. We should make sure that it only merges if CI is ✅ . It's possible that someone changes a chart in prod and |
Looks like Lucas already merged something here: We should check that, and maybe replace it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ETL became much faster & robust since we opened this issue. It should be pretty safe to merge in the middle of the day now. It should take less than hour. |
@lucasrodes there are more ETL performance improvements on the way. I think we can get to a point where merging anytime is not a big deal, and we wouldn't need this. (Rebuilding full ETL takes ~1 hour now and could be sped up by using |
yeah, that makes total sense! thanks for doing that I would still like to explore this whenever I have some time, and have it be an option. but based on earlier discussions, and all the performance improvements this a nice to have, and I shouldn't stress much about it :p |
Sometimes, it would be nice to schedule large PRs to merge overnight when no one is working.
PRs that involve large datasets can often block up the etl for a few hours, which can be problematic for others trying to work.
It looks like there are some ways to do it, described here.
The text was updated successfully, but these errors were encountered: