Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we use our ETL regions everywhere in grapher #2613

Closed
pabloarosado opened this issue May 6, 2024 · 2 comments
Closed

Ensure we use our ETL regions everywhere in grapher #2613

pabloarosado opened this issue May 6, 2024 · 2 comments
Labels
priority 3 - nice to have wontfix This will not be worked on

Comments

@pabloarosado
Copy link
Contributor

Currently, our page on world region definitions uses very old datasets that were manually uploaded. They are not totally consistent with our regions dataset. For example, OWID regions include "French Southern Territories" (visible in the map) as well as other regions that belong to Antarctica.

It would be better to use the indicator from our grapher/regions/2023-01-01/regions dataset. The same applies to WHO and other institution regions (which would need to be added to the garden/regions step).

Similarly, scatter plots use "Continents" from that old manually uploaded dataset, and it would be better to use our regions step. In this case, however, note that:

  • Grapher needs to hide the origin of this dataset. When using the new indicator, it seems that the origin is not hidden (probably because the variable id of the old continents indicator is hardcoded.
  • In this special case, it's not clear to me if here we want to use the grapher indicator, or the external one.
Copy link

stale bot commented Jul 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 18, 2024
@stale stale bot closed this as completed Jul 25, 2024
@pabloarosado pabloarosado reopened this Jul 25, 2024
@stale stale bot removed the wontfix This will not be worked on label Jul 25, 2024
Copy link

stale bot commented Sep 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 28, 2024
@stale stale bot closed this as completed Oct 5, 2024
@larsyencken larsyencken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 3 - nice to have wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants