-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e EgressQoS validation -- account for single stack cluster #4488
Labels
Comments
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Jul 1, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Jul 1, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Jul 2, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Jul 18, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Aug 16, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
jxiaobin
pushed a commit
to jxiaobin/ovn-kubernetes
that referenced
this issue
Aug 16, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Aug 16, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-actions
bot
added
the
lifecycle/stale
All issues (> 60 days) and PRs (>90 days) with no activity.
label
Aug 31, 2024
This issue was closed because it has been stalled for 5 days with no activity. |
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this issue
Sep 6, 2024
Change "e2e EgressQoS Validation" to accommodate cases when the cluster has only one IP family configured. To verify fix, consider using these steps: $ cd .../ovn-kubernetes.git/contrib && \ KIND_IPV4_SUPPORT=true KIND_IPV6_SUPPORT=false \ ./kind.sh && echo ok $ cd ../test/e2e && \ go mod download && \ go test -test.timeout 5m -v . -ginkgo.v \ -ginkgo.focus 'e2e\sEgressQoS\svalidation' \ -ginkgo.flake-attempts 1 -ginkgo.fail-fast \ -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok Fixes: ovn-org#4488 Signed-off-by: Flavio Fernandes <[email protected]>
github-actions
bot
removed
the
lifecycle/stale
All issues (> 60 days) and PRs (>90 days) with no activity.
label
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to see added/updated/deleted in our end-to-end tests?
In a cluster where only ipv4 (or ipv6) is deployed, the e2e tests for EgressQoS validation should skip tests on family that is not configured:
...
• [FAILED] [6.906 seconds]
e2e EgressQoS validation Should validate correct DSCP value on EgressQoS resource changes [It] ipv6 pod before resource
/home/vagrant/dev/ovn-kubernetes.git/test/e2e/egressqos.go:171
[FAILED] error running /usr/local/bin/kubectl --server=https://127.0.0.1:33455 --kubeconfig=/home/vagrant/admin.conf --namespace=egressqos-4476 create -f egressqos.yaml:
Command stdout:
stderr:
The EgressQoS "default" is invalid: spec.egress[0].dstCIDR: Invalid value: "/128": spec.egress[0].dstCIDR in body must be of type cidr: "/128"
error:
exit status 1
In [It] at: /home/vagrant/go/pkg/mod/k8s.io/[email protected]/test/e2e/framework/kubectl/builder.go:91 @ 07/01/24 17:51:06.086
Why is this needed?
Should be able to gracefully handle single stack clusters.
The text was updated successfully, but these errors were encountered: