ef e2e: make sure external containers are running and ready to serve #4484
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm TY @npinaeva ! Verified with: |
flavio-fernandes
previously approved these changes
Jun 28, 2024
|
Funnily enough, the egress firewall test failed on that run https://github.com/ovn-org/ovn-kubernetes/actions/runs/9718311887/job/26826716750?pr=4484 |
before starting the test. Signed-off-by: Nadia Pinaeva <[email protected]>
npinaeva
force-pushed
the
e2e-ext-container
branch
from
65bd4d6
to
fdd1e39
Compare
Signed-off-by: Nadia Pinaeva <[email protected]>
npinaeva
force-pushed
the
e2e-ext-container
branch
from
fdd1e39
to
39b5334
Compare
|
@flavio-fernandes I have got 5 (more or less) green runs, at least no egress firewall failures. Can you please tal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before starting the test.
What this PR does and why is it needed
An attempt to fix #4480
Based on the reported failures, it seems like a problem with the external container connectivity, as some failures happen even before the egress firewall is created.
Can't guarantee that it will fix it though, couldn't reproduce the problem locally.
WIP: trying to get a couple of successful e2e runs (no egress firewall failures), will update when this is done.
1st green run: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9744630959/job/26893660029?pr=4484
2nd green run: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9747524153/job/26901588241?pr=4484
3rd: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9749486954/job/26907766095?pr=4484
4th: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9757083984/job/26929893035?pr=4484
5th: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9759344723/job/26936886909?pr=4484