allocate uninitialized arrays when reading from disk or decoding

Author: ZingBallyhoo

TACTLib/Container/ContainerHandler.cs

@@ -181,7 +181,7 @@ private unsafe ArraySegment<byte> OpenIndexEntry(IndexEntry indexEntry)
             var dataHandle = m_dataFiles[indexEntry.Index];
 
             var size = indexEntry.EncodedSize;
-            var buffer = new byte[size];
+            var buffer = GC.AllocateUninitializedArray<byte>((int)size);
             var bytesRead = RandomAccess.Read(dataHandle, buffer, indexEntry.Offset);
             if (bytesRead != buffer.Length)
             {

TACTLib/Container/StaticContainerHandler.cs

@@ -82,7 +82,7 @@ private string GetFilePath(ulong chunk, ulong archive) {
 
             using var stream = File.OpenRead(GetFilePath(chunk, archive));
             stream.Position = (long)offset;
-            var data = new byte[eSize];
+            var data = GC.AllocateUninitializedArray<byte>(eSize);
             stream.DefinitelyRead(data);
 
             return data;

TACTLib/Core/BLTEDecoder.cs

@@ -77,7 +77,7 @@ public static unsafe byte[] Decode(ClientHandler? client, Span<byte> src) {
             {
                 decodedSize += block.m_decodedSize;
             }
-            var output = new byte[decodedSize];
+            var output = GC.AllocateUninitializedArray<byte>(decodedSize);
             var outputSlice = output.AsSpan();
 
             for (var i = 0; i < blocks.Length; i++)
@@ -87,6 +87,12 @@ public static unsafe byte[] Decode(ClientHandler? client, Span<byte> src) {
                 var blockOutput = SpanHelper.Advance(ref outputSlice, block.m_decodedSize);
                 HandleDataBlock(client, encodedBlockData, blockOutput, i);
             }
+            
+            if (!outputSlice.IsEmpty)
+            {
+                // don't let uninitialized data leak back to caller
+                throw new InvalidDataException("remaining data after decoding all blocks");
+            }
             return output;
         }