Skip to content

Commit 9db6ee1

Browse files
omerdemirokactions-user
authored andcommitted
Remove unused IAMPermissions global variable (#2831)
The IAMPermissions global map was being populated but never read or used. IAM permissions are already properly tracked through: - The IAMPermissions field in AdapterMeta struct (for dynamic adapters) - The IAMPermissions() method interface (for manual adapters) Changes: - Deleted sources/gcp/shared/iam-permissions.go - Removed code that populated the global map in adapters.go - Removed 4 occurrences of population code in transformer.go The code compiles and all tests pass after these changes. GitOrigin-RevId: a327618997c6bcf7c1601bd2b8ba05d7c5fc83c0
1 parent 13718b1 commit 9db6ee1

File tree

3 files changed

+0
-36
lines changed

3 files changed

+0
-36
lines changed

sources/gcp/dynamic/adapters.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,6 @@ func MakeAdapter(sdpItemType shared.ItemType, linker *gcpshared.Linker, httpCli
141141
ListResponseSelector: meta.ListResponseSelector,
142142
}
143143

144-
// Add IAM permissions to the global map
145-
for _, perm := range meta.IAMPermissions {
146-
gcpshared.IAMPermissions[perm] = true
147-
}
148-
149144
switch adapterType(meta) {
150145
case SearchableListable:
151146
searchEndpointFunc, err := meta.SearchEndpointFunc(opts...)

sources/gcp/shared/iam-permissions.go

Lines changed: 0 additions & 7 deletions
This file was deleted.

sources/transformer.go

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,6 @@ func WrapperToAdapter(wrapper Wrapper) StandardAdapter {
130130
panic(fmt.Sprintf("failed to validate adapter: %v", err))
131131
}
132132

133-
if iamPerms := wrapper.IAMPermissions(); len(iamPerms) > 0 {
134-
for _, perm := range iamPerms {
135-
gcpshared.IAMPermissions[perm] = true
136-
}
137-
}
138-
139133
return a
140134
}
141135

@@ -153,12 +147,6 @@ func WrapperToAdapter(wrapper Wrapper) StandardAdapter {
153147
panic(fmt.Sprintf("failed to validate adapter: %v", err))
154148
}
155149

156-
if iamPerms := wrapper.IAMPermissions(); len(iamPerms) > 0 {
157-
for _, perm := range iamPerms {
158-
gcpshared.IAMPermissions[perm] = true
159-
}
160-
}
161-
162150
return a
163151
}
164152

@@ -177,12 +165,6 @@ func WrapperToAdapter(wrapper Wrapper) StandardAdapter {
177165
panic(fmt.Sprintf("failed to validate adapter: %v", err))
178166
}
179167

180-
if iamPerms := wrapper.IAMPermissions(); len(iamPerms) > 0 {
181-
for _, perm := range iamPerms {
182-
gcpshared.IAMPermissions[perm] = true
183-
}
184-
}
185-
186168
return a
187169
}
188170

@@ -195,12 +177,6 @@ func WrapperToAdapter(wrapper Wrapper) StandardAdapter {
195177
panic(fmt.Sprintf("failed to validate adapter: %v", err))
196178
}
197179

198-
if iamPerms := wrapper.IAMPermissions(); len(iamPerms) > 0 {
199-
for _, perm := range iamPerms {
200-
gcpshared.IAMPermissions[perm] = true
201-
}
202-
}
203-
204180
return a
205181
}
206182

0 commit comments

Comments
 (0)