From 08549141e2f8d18973605e9083c80c3c2c808aa7 Mon Sep 17 00:00:00 2001
From: Danyal Faheem <138459282+Danyal-Faheem@users.noreply.github.com>
Date: Thu, 4 Jul 2024 11:32:53 +0500
Subject: [PATCH] fix: add turn on mysql-native-password authentication plugin
 to fix broken connection for users upgrading from Tutor 15 or earlier (#1090)

* fix: add --mysql-native-password=ON param to fix broken connection, fixes #1089
For tutor instances that were created with tutor 15 and earlier and then upgraded to tutor 18, the launch process would fail as MySQL connection could not be made. This is because mysql-native-password was removed in MySQL 8.4.0. We turn it on temporarily to fix failing connections.
---
 ...0704_112127_danyal.faheem_fix_mysql_native_password_plugin.md | 1 +
 tutor/templates/k8s/deployments.yml                              | 1 +
 tutor/templates/local/docker-compose.yml                         | 1 +
 3 files changed, 3 insertions(+)
 create mode 100644 changelog.d/20240704_112127_danyal.faheem_fix_mysql_native_password_plugin.md

diff --git a/changelog.d/20240704_112127_danyal.faheem_fix_mysql_native_password_plugin.md b/changelog.d/20240704_112127_danyal.faheem_fix_mysql_native_password_plugin.md
new file mode 100644
index 0000000000..edfd9f40ca
--- /dev/null
+++ b/changelog.d/20240704_112127_danyal.faheem_fix_mysql_native_password_plugin.md
@@ -0,0 +1 @@
+- [Bugfix] Fix `mysql-native-password is not loaded` error in MySQL 8.4 when upgrading from tutor 15 or an earlier release to tutor 18 by enabling the plugin. (by @Danyal-Faheem)
\ No newline at end of file
diff --git a/tutor/templates/k8s/deployments.yml b/tutor/templates/k8s/deployments.yml
index ee4e9e8573..778118b511 100644
--- a/tutor/templates/k8s/deployments.yml
+++ b/tutor/templates/k8s/deployments.yml
@@ -397,6 +397,7 @@ spec:
             - "--character-set-server=utf8mb4"
             - "--collation-server=utf8mb4_unicode_ci"
             - "--binlog-expire-logs-seconds=259200"
+            - "--mysql-native-password=ON"
           env:
             - name: MYSQL_ROOT_PASSWORD
               value: "{{ MYSQL_ROOT_PASSWORD }}"
diff --git a/tutor/templates/local/docker-compose.yml b/tutor/templates/local/docker-compose.yml
index aaa9601da0..14e141434d 100644
--- a/tutor/templates/local/docker-compose.yml
+++ b/tutor/templates/local/docker-compose.yml
@@ -44,6 +44,7 @@ services:
       --character-set-server=utf8mb4
       --collation-server=utf8mb4_unicode_ci
       --binlog-expire-logs-seconds=259200
+      --mysql-native-password=ON
     restart: unless-stopped
     user: "999:999"
     volumes: