Skip to content

Commit 829adf2

Browse files
committed
fix: docker build deprecation warnings
With the latest Docker upgrade, we got the following warnings during build: FromAsCasing: 'as' and 'FROM' keywords' casing do not match LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
1 parent 906533b commit 829adf2

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- [Bugfix] Fix legacy warnings during Docker build. (by @regisb)

tutorforum/templates/forum/build/forum/Dockerfile

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ RUN useradd --home-dir /app --create-home --shell /bin/bash --uid 1000 app
1616
USER app
1717

1818
# Install rake and bundler
19-
ENV PATH "/app/.gem/ruby/3.0.4/bin:$PATH"
19+
ENV PATH=/app/.gem/ruby/3.0.4/bin:$PATH
2020
RUN gem install --user-install bundler --version 2.3.4
2121
RUN gem install --user-install rake --version 13.0.6
2222

@@ -27,7 +27,7 @@ RUN git clone $FORUM_REPOSITORY --branch $FORUM_REPOSITORY_VERSION --depth 1 /ap
2727

2828
# Install ruby requirements
2929
WORKDIR /app/cs_comments_service
30-
ENV BUNDLE_GEMFILE Gemfile3
30+
ENV BUNDLE_GEMFILE=Gemfile3
3131
RUN bundle config set --local deployment 'true'
3232
RUN bundle install
3333

@@ -36,13 +36,13 @@ COPY --chown=app:app ./bin/docker-entrypoint.sh /app/bin/docker-entrypoint.sh
3636
RUN chmod a+x /app/bin/docker-entrypoint.sh
3737
ENTRYPOINT ["/app/bin/docker-entrypoint.sh"]
3838

39-
ENV SINATRA_ENV staging
40-
ENV NEW_RELIC_ENABLE false
41-
ENV API_KEY forumapikey
42-
ENV SEARCH_SERVER "http://elasticsearch:9200"
43-
ENV MONGODB_AUTH ""
44-
ENV MONGODB_HOST "mongodb"
45-
ENV MONGODB_PORT "27017"
46-
ENV MONGODB_DATABASE "cs_comments_service"
39+
ENV SINATRA_ENV=staging
40+
ENV NEW_RELIC_ENABLE=false
41+
ENV API_KEY=forumapikey
42+
ENV SEARCH_SERVER=http://elasticsearch:9200
43+
ENV MONGODB_AUTH=""
44+
ENV MONGODB_HOST=mongodb
45+
ENV MONGODB_PORT=27017
46+
ENV MONGODB_DATABASE=cs_comments_service
4747
EXPOSE 4567
4848
CMD ./bin/unicorn -c config/unicorn_tcp.rb -I '.'

0 commit comments

Comments
 (0)